search

petrbroz / svf-utils

Utilities for working with the SVF file format used by Autodesk Platform Services.
https://petrbroz.github.io/svf-utils/
MIT License
123 stars 53 forks source link

Get internal properties of node #35

Closed johannesheesterman closed 3 years ago

johannesheesterman commented 3 years ago

What is the reasoning for skipping the 'internal attributes' in the getProperties method of the PropDbReader? https://github.com/petrbroz/forge-convert-utils/blob/b5ea5e6a9620a61ab73e64e3b70c1b77e2660555/src/common/propdb-reader.ts#L60

It would be very useful for me if I could directly access these properties.

johannesheesterman commented 3 years ago

I just realised I could just use: Array.from(propDbReader.enumerateProperties(node.dbid));

petrbroz commented 3 years ago

Hi Johannes, I intentionally skipped the __*__ properties because those are not the "typical properties" (i.e., not the properties you would see in the Properties dialog in Forge Viewer). Those properties are supposed to include type of information such as parent-child relationships between different objects in the scene.

If there are strong arguments to include these properties in the list, I'd be happy to remove the if-condition.