search

petrbroz / svf-utils

Utilities for working with the SVF file format used by Autodesk Platform Services.
https://petrbroz.github.io/svf-utils/
MIT License
123 stars 53 forks source link

Experimental/svf2 #71

Closed AlexPiro closed 1 year ago

AlexPiro commented 1 year ago

Experiments on SVF2 based on your work with OTG. Most part of the client / reader / parser are identical. I added the IMF part for SVF2 (as was done for SVF), but I think some of the logic should be done during the parsing.

My code is a little messy, let me know if you want me to clean it before pull request. 😉

petrbroz commented 1 year ago

Hi Alex, yeah, this PR looks quite scary :D If you could clean it up, that'd certainly help.

petrbroz commented 1 year ago

Btw good timing! We're now discussing re-introducing SVF2 into the converter within our team, so we definitely want to move in this direction. The only question is how we do that. The experimental/otg branch I created in the past is probably very outdated now, so we may actually be better off just reusing some of its pieces, and create a new branch off of develop.

AlexPiro commented 1 year ago

I added a new branch from develop and cleaned a little my code, but I can't pull request on a new branch. Can you create a new one that I can pull request on ?