Download SVF doesn't set the output folder name as the bucket's object name

petrbroz / vscode-forge-tools

Visual Studio Code extension for accessing Autodesk Forge services and content.

https://marketplace.visualstudio.com/items?itemName=petrbroz.vscode-forge-tools

MIT License

74 stars 17 forks source link

Download SVF doesn't set the output folder name as the bucket's object name #27

Closed fpmalard closed 4 years ago

fpmalard commented 4 years ago

Screen Shot 2020-06-10 at 14 00 16

petrbroz commented 4 years ago

Correct. That's because the OSS object name may contain unsafe characters. I'd be happy to change the naming of the folders to something else, as long as the names are guaranteed to be safe. Any suggestions?

ofcdesk commented 4 years ago

Indeed. Maybe you can validate the object name and then:

If it does have all safe chars use its name as the target folder
If it doesn't, use the Id the way it is now

petrbroz commented 4 years ago

I'm not sure if that's a good idea. I'd prefer some consistent approach where the naming would always behave the same way. Maybe we could just sanitize the name of the objects, but even then, it would be less intuitive to create an output folder called say house.rvt, and store the output in it...