search

petrelharp / ftprime_ms

4 stars 2 forks source link

Edits: mostly to intro #41

Closed ashander closed 6 years ago

ashander commented 6 years ago

Major suggested changes:

Also two things which may require punting to discussion on a separate issue:

I tried to break things into discrete commits

ashander commented 6 years ago

I'll be offline till later today or tomorrow. @petrelharp you're forging ahead and want to merge/edit this first feel free

petrelharp commented 6 years ago

We'll see; I'll probably get distracted here soon and will let you figure out what you want to do with my suggestions.

ashander commented 6 years ago

👍

On Sat, Dec 30, 2017 at 09:47 Peter Ralph notifications@github.com wrote:

We'll see; I'll probably get distracted here soon and will let you figure out what you want to do with my suggestions.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/petrelharp/ftprime_ms/pull/41#issuecomment-354558978, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfLOK1gn6ZtscE1hparjVE36ltnfqbHks5tFncfgaJpZM4RPhPe .

-- -Jaime

petrelharp commented 6 years ago

Apologies for the various deleted comments, wherein I said "why don't you do this" and then realized you already had. :sheepish grin:

petrelharp commented 6 years ago

dammit, accidentally clicked "close and comment"

petrelharp commented 6 years ago

Looks good! Thanks! Will wait to close until a non-vacation day. =)

ashander commented 6 years ago

FYI @molpopgen & co I'm happy if y'all think we should retain the more detailed discussion of supp fig in main text —just wanted to see moving it would look like.

Looks good! Thanks! Will wait to close until a non-vacation day. =)

Cool good call.

-- -Jaime

ashander commented 6 years ago

Ok thanks for those comments I've fixed or responded to them.

We can probably leave discussion of formatting and term for fwdpp to another issue if need be.

ashander commented 6 years ago

This is good to merge from my end.

After looking at this in #42 I've added a comment that RAM use is actually less in simuPOP with pedigree tracking. See below

image