Closed molpopgen closed 6 years ago
Oh... sorry requesting changes leaves that ugly red X
I realize the earlier email wasn't super clear on retaining some of the simuPOP result. That was the intention of:
- We would put current results in the appendix in place of the 'neutral' results, and could still refer to them, semi-tangentially.
But: I think we wanted to keep simuPOP in the figs related to neutral. I comment on the relevant lines below but the figs are
As I understood, plan was to dump simupop. If we keep neutral, gotta rerun the selected...
We would put current results in the appendix in place of the 'neutral' results, and could still refer to them, semi-tangentially.
But we, or at least I, no longer know what those results represent.
yes. good point and I agree. I don't agree either with the plain language of
We would put current results in the appendix in place of the 'neutral' results, and could still refer to them, semi-tangentially.
regarding current results in the main text. but think retaining ~neutral~ without selection results is worth it
Did a forced update, as the changes weren't really revertible before.
what is the conclusion: leave simupop in appendix or not? "leave in" maybe the easiest?
How about:
I'll do the simupop edit, with "leave it in" using these figs. If we decide that's bad, @molpopgen 's earlier work to remove it completely is preserved here https://github.com/petrelharp/ftprime_ms/tree/remove-simupop-fully
ok great.
oops. now this
@molpopgen 's earlier work to remove it completely is preserved here https://github.com/petrelharp/ftprime_ms/tree/remove-simupop-fully
is actually true praise the reflog
update figures to remove simupop