Closed jeromekelleher closed 6 years ago
Number 1 could to in intro, as it is part of an overview of existing literature.
For number 2, GWAS-sized samples are one application. And, pop-gen is just getting bigger, at least in some systems.
Currently, the introduction (1 pg) does:
and the discussion (1 pg) does:
"The ARG bit" being this ? https://github.com/petrelharp/ftprime_ms/blob/60b31af5de68e5f30cba0a25d9b507a0e163c2fc/forwards_paper.tex#L322-L335 good call
I guess the alternatives are these:
I'm fine with either.
Oh and the phrase "much more limited" in discussing the 08 paper would be nicer if a bit more concrete https://github.com/petrelharp/ftprime_ms/blob/60b31af5de68e5f30cba0a25d9b507a0e163c2fc/forwards_paper.tex#L962-L963
I like the suggestion of moving prior work to the intro. I think the reason it ended up in the discussion was because we wanted to contrast what they did to what we do, which is easier after the reader knows what we do.
I could write more about how big simulations are important for the parallelization section. But, I think the point is fairly tangential: it's in the category of "things I generally want to say" but aren't actually important for this paper.
So: I think my proposal is to move the 'previous work' to the Intro, as Kevin says, and remove the 'parallelization' bit. Then the discussion would be much more tightly focused. I'll give this a go in a PR.
So: I think my proposal is to move the 'previous work' to the Intro, as Kevin says, and remove the 'parallelization' bit. Then the discussion would be much more tightly focused. I'll give this a go in a PR.
This sounds good.
So: I think my proposal is to move the 'previous work' to the Intro, as Kevin says, and remove the 'parallelization' bit. Then the discussion would be much more tightly focused. I'll give this a go in a P
+1
done; thanks all.
The discussion doesn't really have any narrative flow at the moment, and is pretty obviously a collection of things that we didn't know where to put.
What do we do with the ana-fits paragraph? We clearly need to say something like this, but it's out of place in the discussion at the moment. Where else could it go? Perhaps at the end of the 'Recording the pedigree forwards in time' section?
The parallelisation paragraph is sticking out a bit too. Unless we fill this out with some further discussion about why we'd need to do these large simulations or something, I think we should find a different place for it.
I don't have a concrete idea for the actual narrative of the discussion yet; I thought I'd start the discussion here and see what you guys thought.