search

petrelharp / ftprime_ms

4 stars 2 forks source link

Add cpp code #84

Closed molpopgen closed 5 years ago

molpopgen commented 5 years ago
  1. Add the code from my repo
  2. Add a README for this repo
petrelharp commented 5 years ago

Looks good! We should perhaps explicitly clarify that the example actually does need msprime 0.5.0 to run, and some minor changes would be needed to run with the current version: I just tested it with a more recent version and got

    trees.dump_tables(nodes=self.__nodes, edges=self.__edges)
TypeError: dump_tables() got an unexpected keyword argument 'nodes'

How about

**Note:** This code uses msprime version 0.5.0 (installed in the example below using conda). To make it work with a more recent msprime version, some minor changes would be needed.
molpopgen commented 5 years ago

Done.

On Thu, Oct 11, 2018 at 9:38 AM Peter Ralph notifications@github.com wrote:

Looks good! We should perhaps explicitly clarify that the example actually does need msprime 0.5.0 to run, and some minor changes would be needed to run with the current version: I just tested it with a more recent version and got

trees.dump_tables(nodes=self.__nodes, edges=self.__edges)

TypeError: dump_tables() got an unexpected keyword argument 'nodes'

How about

Note: This code uses msprime version 0.5.0 (installed in the example below using conda). To make it work with a more recent msprime version, some minor changes would be needed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/petrelharp/ftprime_ms/pull/84#issuecomment-429027046, or mute the thread https://github.com/notifications/unsubscribe-auth/AGHnH_tKYwFqNN0ItE2mwsWQYff6OumKks5uj3PFgaJpZM4XTlXT .

ashander commented 5 years ago

Looks good to me. Thanks Kevin!

petrelharp commented 5 years ago

Rad; thanks.