search

petrelharp / treestats_ms

1 stars 1 forks source link

Krt edits and comments #16

Closed molpopgen closed 5 years ago

molpopgen commented 5 years ago

So far, this is covering the 1/3 of the paper or so. Will be pushing more until the end of today (Friday).

petrelharp commented 5 years ago

Looks good, thanks. I've commented on some things, but haven't said anything about your comments that I just need to do something about/fix.

petrelharp commented 5 years ago

Big picture question is whether we should write a section on "implementation of new statistics" in tihs paper that discusses polarisation, strict, etcetera. My vote is no, and that this should be a section of the documentation instead: this paper is about the theoretical framework not the details of the API.

molpopgen commented 5 years ago

Big picture question is whether we should write a section on "implementation of new statistics" in tihs paper that discusses polarisation, strict, etcetera. My vote is no, and that this should be a section of the documentation instead: this paper is about the theoretical framework not the details of the API.

I agree overall. But discussions like this are important b/c they show that the docs cannot say, "refer to the paper for details", at least not yet.

petrelharp commented 5 years ago

Merging; will edit there (and resisting the urge to squash + rebase...)