search

petrhruby97 / learning_minimal

Learning to Solve Hard Minimal Problems
Other
141 stars 18 forks source link

Copyright / License Notice #4

Open rfabbri opened 2 years ago

rfabbri commented 2 years ago

Dear Petr Hrubý,

Congratulations for your great work. I am glad to see source code derived from MINUS (https://github.com/rfabbri/minus) being widely useful. However, there are licensing issues that need to be addressed.

MINUS has an explicit LICENSE file in its sourcecode: https://github.com/rfabbri/minus/blob/master/LICENSE

Which mentions explicit copyright and conditions to be met:

MINUS - MInimial problem NUmerical continuation Solver Released under the BSD 2-Clause License:

Copyright (c) 2019 Ricardo Fabbri, Anton Leykin and Timothy Duff

Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

  1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. ...

Your path tracking source code in: https://github.com/petrhruby97/learning_minimal/blob/1a0d31870f280da81b33ab77aba413cb0c45812a/5p2v/src/homotopy.hxx#L1886

Derives from MINUS source code in: https://github.com/rfabbri/minus/blob/f01e1b72eef1a15184998d25d30f6b54564a9c17/minus/minus.hxx#L26

There is a number of other places that the code derives from MINUS, but the license conditions have not been met. For instance:

Your source code in: https://github.com/petrhruby97/learning_minimal/blob/1a0d31870f280da81b33ab77aba413cb0c45812a/4p3v/src/homotopy.hxx#L126

Derives from MINUS source code in: https://github.com/rfabbri/minus/blob/master/minus/internal-util.h

Your source code in: https://github.com/petrhruby97/learning_minimal/blob/1a0d31870f280da81b33ab77aba413cb0c45812a/5p2v/src/homotopy.hxx#L386

Derives from MINUS source code in (different evaluator, but same code style): https://github.com/rfabbri/minus/blob/master/minus/chicago14a.hxx

The specific programming practice used in MINUS was the outcome of my efforts to optimize Homotopy Continuation. Therefore, the resulting style and C/C++ constructs are unique and traceable.

Please realize that I admire your work, I am just reminding you that the LICENCE conditions be met. In addition to the aforementioned legal LICENCING terms, I would like remind you that it is good scholarly practice to kindly credit the sources of your work in the README.

Thank you for your work, I will for sure use it myself and cite it. Ricardo Fabbri

petrhruby97 commented 2 years ago

Dear Ricardo Fabbri,

Thank you for noticing me about the license issues. I have added the license file into the repository. Is it OK now?

Best Petr Hrubý