Wrong initialization of DOFs in "Default"

petrikosk / rsruckig

Rust port of Ruckig trajectory generator

https://ruckig.com

MIT License

5 stars 4 forks source link

Wrong initialization of DOFs in "Default" #6

Closed v-morlock closed 4 months ago

v-morlock commented 6 months ago

Hey Petri!

Thanks for getting back and for adding the DOFs as const-generics! I just started to play with rsruckig again and found that the "Default" implementation seems to not always respect the DOFs (e.g. InputParameter.enabled does initialize an empty vector when using ..Default::default())

I'd be happy to provide a PR to fix that but i wanted to let you know first, in case you've got any thoughts on it and to quickly check whether you'd accept such a fix.

Thanks and best, Valentin

petrikosk commented 6 months ago

Hi Valentin!

Thanks for pointing out the issue. I'd be happy to see your PR, if you already have one and merge it.

All the best, Petri

petrikosk commented 6 months ago

Please see this commit: https://github.com/petrikosk/rsruckig/commit/c719101d084d84a1b303c9eef8e66520a2a2f748