search

petrikvladimir / pyphysx

Python Wrapper for Nvidia PhysX simulator.
GNU General Public License v3.0
102 stars 21 forks source link

build from source on windows #55

Closed yzhao334 closed 2 years ago

yzhao334 commented 2 years ago

Thanks a lot for the update for windows. I was trying to build it from source but always get error message: 'xxx requires /std:c++17'. How can I change the c++ standard?

petrikvladimir commented 2 years ago

Hi, can you please share the full output of the build process? PyPhysx requires c++14, but maybe some of the dependencies need 17. This will be visible (I hope) in the error message of the build process.

yzhao334 commented 2 years ago

image

petrikvladimir commented 2 years ago

Thanks! So it's indeed my error... I will remove nodiscard operator, it's not needed in this case anyway. will push/merge the fix soon.

petrikvladimir commented 2 years ago

Merged, please try it and if there are any issues, feel free to reopen or create a new one. Thanks for reporting this bug!

yzhao334 commented 2 years ago

Thanks a lot for the quick fix! The building is working properly on my windows PC now.