search

petrkotek / chromecastize

Bash script to convert video files into Google Chromecast supported format.
MIT License
178 stars 34 forks source link

Fixes for directory traversal and filenames with spaces #24

Closed elijah-taylor closed 9 years ago

elijah-taylor commented 9 years ago

Hi Petr,

Great script! I made some local edits for the use case of converting all the content on my NAS. The readme mentions the ability to use a directory as an input so I assume this regressed at some point. I also had some files with spaces in the name, and your "for in" was delimiting filenames from "find" with spaces, so I changed it to delimit with \0 and parse it out.

I hope you don't find my whitespace change too aggressive, but I normally view content with tabs rendered as two spaces, and there were quite a few inconsistencies between using tabs vs spaces in the script, so I normalized them. Feel free to ignore this change and fix-up the others to match whitespace.

-Elijah

elijah-taylor commented 9 years ago

shoot, I found a couple bugs in my changes, let me fix the changes with a history rewrite and I'll issue a new pull request