petrkotek / chromecastize

Bash script to convert video files into Google Chromecast supported format.
MIT License
178 stars 34 forks source link

Is the avconv check necessary? #26

Closed DrCherry closed 7 years ago

DrCherry commented 8 years ago

I'm running arch and since there's no avconv utility, I simply removed it from the check and everything seems to be working as it should. Is the check for avconv necessary for other distros? If not, I'd like to propose it be removed, I can issue a pull request...

murzz commented 8 years ago

Some distros have livab instead of ffmpeg, that’s why the check was added.

petrkotek commented 8 years ago

correct - libav (i.e. avconv) and ffmpeg are more or less compatible, so either of them can be used.

@DrCherry you mentioned, that it works fine without the check, but i believe it works fine even with the check, is that correct?

pfrenssen commented 7 years ago

I have committed a fix in #34 that suppresses the error message on systems such as Arch that do not have avconv installed.