search

petrkotek / chromecastize

Bash script to convert video files into Google Chromecast supported format.
MIT License
178 stars 34 forks source link

fix directory mode #31

Closed frawa closed 7 years ago

frawa commented 7 years ago

take parameter in function process_file

pfrenssen commented 7 years ago

I tried running this on a directory. Before I applied the fix I got the following error message:

$ chromecastize.sh my\ folder/
my folder/: Is a directory

But after applying it the process still failed because at some point the filename gets split on spaces.

frawa commented 7 years ago

Does it work with a directory name with no blanks? In that case I propose to split the two issues. Fixing director mode first, and look at the blanks in names problem next, which was already raised as #22.

pfrenssen commented 7 years ago

I just checked, it does work as expected with a filename without spaces. You're right, that's out of scope for this PR. Merging into master, thanks for the fix!