h264 profile and level check

petrkotek / chromecastize

Bash script to convert video files into Google Chromecast supported format.

MIT License

178 stars 34 forks source link

h264 profile and level check #68

Open DeFiYaco opened 3 years ago

DeFiYaco commented 3 years ago

script checks h264 profile and level
config does not need .sh extension since there are only variables inside

I will keep this PR as draft until I test with more videos and add more supported and unsupported profiles and levels. Feel free to comment if you do not agree with some of my changes.

pfrenssen commented 3 years ago

Chromecast Ultra supports up to L5.2 I believe. We might need to dig up the official documentation to know exactly which version supports what.

DeFiYaco commented 3 years ago

Chromecast Ultra supports up to L5.2 I believe. We might need to dig up the official documentation to know exactly which version supports what.

Yes, that is correct. I am slowly testing with different video formats just to be sure. This is the reference: https://developers.google.com/cast/docs/media I will update supported and unsupported formats in the script accordingly.

pfrenssen commented 3 years ago

Probably it is not needed to maintain both the SUPPORTED and UNSUPPORTED profiles. I think just listing the supported ones should be sufficient.

DeFiYaco commented 3 years ago

True, it will make maintaining easier in the future if we just list what is supported. That is changed now along with reverting config to the config.sh.