search

petrleocompel / hikaxpro_hacs

HACS repository of Hikvision Ax Pro integration for home assistant
MIT License
45 stars 4 forks source link

Replace fixed strings in sensor.py to use language file #13

Closed DejanBukovec closed 1 year ago

DejanBukovec commented 1 year ago

In sensor.py we need to change that some fixed strings use language file.

Slovenian translations: Unknown = Neznan Magnet presence = Prisotnost magneta Temperature = Temperatura Humidity = Vlažnost Battery = Baterija Signal = Signal Tamper = Sabotaža Bypass = Obhod Armed = Omogočen Alarm = Alarm Stay away = Omogočen zunaj Is via repeater = Povezan preko ponavljalnika

petrleocompel commented 1 year ago

I understand. Sadly my knowledge is not that high so I have to look in HA Docs and search how to translate these attributes.

DejanBukovec commented 1 year ago

Maybe this help you: https://developers.home-assistant.io/docs/internationalization/core/#entity-attribute-name-and-state-of-entity-components

petrleocompel commented 1 year ago

Found it already 😊. Just too much to focus on. It will take some time to make it right.

petrleocompel commented 1 year ago

So I am unsure if we should try... Even official integrations are not translated.

image

Also it is customizable. So it is up to user to change and set it up

image

I think if you agree until HA docs will say to do it we would keep the basics. Otherwise you can customize your entitites in HA yourself.

DejanBukovec commented 1 year ago

Ok no problem, then leave it as is :) I think that most or all integrations have fixed English name as Im quick check...

petrleocompel commented 1 year ago

Closing for now