petrolpark / Destroy

A chemistry-themed add-on to the Minecraft mod, Create
https://modrinth.com/mod/destroy
84 stars 33 forks source link

ore electrolyzation is being finnicky 2 electric boogaloo #122

Closed FriedShramp closed 8 months ago

FriedShramp commented 8 months ago

I have gone and fixed all of my previous mistakes but the ore still will not electrolyze. I realize this is still most likely a mistake on my part but I feel it could be a bug. The dynamo is rotating at the maximum speed. I have used a test tube to show concentrations of basin contents, (just a suggestion but I think goggles should show concentrations of contents if you sneak or something, using a test tube can be annoying in creative mode as it just removes fluid by default) The dynamo was tested rotating in both directions.

2024-01-11_16 53 57 2024-01-11_16 54 16

I am utterly lost as to what is going on. Also here is a screenshot of my mods list: image

helloworld069 commented 8 months ago

I managed to recreate this. image I got such a test tube of solution from the beneath showing vat, and it doesn't work with the identical device I used in the reply to the previous issue. image By the way, I suggest using an exact number to describe the leeway instead of using a vague 'approximately'. In addition, the 'M' is used as a unit for both concentration(in test tubes) and quantity(in vats), I wonder if we could separate them to avoid confusion.

petrolpark commented 8 months ago

I'll relabel the electrolysis tooltip with exact values, and change the info shown with the Vat display link (technically, it does already show concentration, but with respect to the whole Vat. That's not very obvious though).

Could you run /data get block <basin coordinates> and tell me what you get? I think in your case, you might have an iron concentration of 4.14 or something. That's not ideal as it still shows as 4.1 so you'd expact that to react.

helloworld069 commented 8 months ago

Here's the result of mine image Seems that the concentration of iron(III) is 4.127, while that of the solution I used in the previous issue was 4.089, which worked for this recipe.

petrolpark commented 8 months ago

I'll probably replace it with a range (e.g. "at a concentration between 3.5M and 4.5M"). As you've been very helpful with bug reports @helloworld069, if you want you can DM me on Discord (petrolpark) and I'll add the Beta Tester Badge. (You're also owed the translator Badge, if you want that).

FriedShramp commented 8 months ago

If you make the inequality as 3.5 and 4.545M it will stop these strange occurrences where rounding makes it feel like it’s broken :)

petrolpark commented 8 months ago

This has now been implemented in 0.4.