Assignment in if statement

petrpavlu / valgrind-riscv64

Valgrind with support for the RISCV64/Linux platform.

GNU General Public License v2.0

56 stars 16 forks source link

Assignment in if statement #18

Closed paulfloyd closed 5 months ago

paulfloyd commented 5 months ago

https://github.com/petrpavlu/valgrind-riscv64/blob/0a389c93602c9847eed7fd28fd2934c9e5721387/VEX/priv/guest_riscv64_toIR.c#L1621

priv/guest_riscv64_toIR.c:1621:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
 1621 |          if (fm = 0b1000)
      |              ^~

Should probably be "=="

petrpavlu commented 5 months ago

Thanks, fixed in 8107c9e58299e826eaa933abf83860bd4ee3cf50.