petrroll / PowerSwitcher

Power plan switcher for Windows 10. Heavily inspired by EarTrumpet.
MIT License
334 stars 49 forks source link

the animation is not smooth enough #21

Open sage9731 opened 5 years ago

Gaalidas commented 4 years ago

I'm not really in the position to make any fixes here, since it's not my application... but here's where the smoothness could possibly be made better. Currently the animation duration is set to 0.2 for hiding and 0.3 for showing, in seconds. that's pretty freakin' fast.

In the file "PowerSwitcher.TrayApp\Extensions\WindowExtensions.cs" there is something that looks like: Duration = new Duration(TimeSpan.FromSeconds(0.3)), and, I suspect, you could change that double in the last position to something more to your liking (such as 0.4/0.5) to make it animate smoother. I'm not in a position to test this, but it's a possibility if you want to break free of the windows store and compile your own copy for personal use.

petrroll commented 4 years ago

While it might help it's not the cause of the issue. I remember trying to make the animation smooth but nothing seemed to work properly.

Also I'm using modified flyout lifted from eartrumpet so maybe just updating my version to their newest version might improve things. That said, last time I've checked they still had the same animation framerate issue.

Tbh I think it's just wpf's animation system fault, tho can't say that for certain.

On Sat, Oct 5, 2019, 19:53 Gaalidas notifications@github.com wrote:

I'm not really in the position to make any fixes here, since it's not my application... but here's where the smoothness could possibly be made better. Currently the animation duration is set to 0.2 for hiding and 0.3 for showing, in seconds. that's pretty freakin' fast.

In the file "PowerSwitcher.TrayApp\Extensions\WindowExtensions.cs" there is something that looks like: Duration = new Duration(TimeSpan.FromSeconds(0.3)), and, I suspect, you could change that double in the last position to something more to your liking (such as 0.4/0.5) to make it animate smoother. I'm not in a position to test this, but it's a possibility if you want to break free of the windows store and compile your own copy for personal use.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/petrroll/PowerSwitcher/issues/21?email_source=notifications&email_token=AANO24KSIZT2CKZKD7DP6IDQNDH7XA5CNFSM4ILQLH42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEANYAZY#issuecomment-538673255, or mute the thread https://github.com/notifications/unsubscribe-auth/AANO24LQRHZWGZZ6I4UG7GLQNDH7XANCNFSM4ILQLH4Q .

petrroll commented 4 years ago

Unfortunately I've stopped development of this app so I (most probably) won't be looking at sorting this personally. Feel free to contribute a PR/create a fork, will be happy to help with that.

More info in #23

petrroll commented 4 years ago

relevant: #24