search

petrroll / PowerSwitcher

Power plan switcher for Windows 10. Heavily inspired by EarTrumpet.
MIT License
349 stars 49 forks source link

Add application trigger #27

Open aliask opened 4 years ago

aliask commented 4 years ago

This pull requests adds the functionality to switch power plans when an application starts or stops.

New configuration items have been added for:

Note that this functionality requires that the app be given administrator privileges.

petrroll commented 4 years ago

Hi! First off, amazing work! Happy to see that my code is still useful after all this time. Unfortunately I'll not be merging the PR at the moment for two reasons:

1) I don't feel like making the app admin only as I generally don't like giving admin permissions to apps. Also, I'm not quite sure how the requireAdministrator plays together with MSIX/AppX "container" / if it's possible to have based-on-settings admin privileges, etc. 2) As of right now I don't have the time (#23) to rework the packaging pipeline so even if 1) wasn't an issue I'd still not build a publish a new version.

Given that I see little reason to merge this in master. If someone wants to build their own version with app trigger support they can just just clone your fork and use it.

Alternatively, I'd be happy to create a separate branch for this feature on this repo and you can merge into that one. I'll remember to keep it in sync with master if I ever come back to developing this.

I hope you understand. :)

aliask commented 4 years ago

Hi Petr,

I completely get it - I had the same annoyance when I found out it would require admin access too. To be honest I just wanted this feature myself and had some time on my Sunday, and thought I may as well share the results.

Hopefully someone finds it useful!

Cheers, Will

On Sun, 31 May 2020, 10:18 pm Petr Houška, notifications@github.com wrote:

Hi! First off, amazing work! Happy to see that my code is still useful after all this time. Unfortunately I'll not be merging the PR at the moment for two reasons:

  1. I don't feel like making the app admin only as I generally don't like giving admin permissions to apps. Also, I'm not quite sure how the requireAdministrator plays together with MSIX/AppX "container" / if it's possible to have based-on-settings admin privileges, etc.
  2. As of right now I don't have the time (#23 https://github.com/petrroll/PowerSwitcher/issues/23) to rework the packaging pipeline so even if 1) wasn't an issue I'd still not build a publish a new version.

Given that I see little reason to merge this in master. If someone wants to build their own version with app trigger support they can just just clone your fork and use it.

Alternatively, I'd be happy to create a separate branch for this feature on this repo and you can merge into that one. I'll remember to keep it in sync with master if I ever come back to developing this.

I hope you understand. :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/petrroll/PowerSwitcher/pull/27#issuecomment-636463490, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPOQXPHJKIGPN476GF5IPTRUJDH7ANCNFSM4NPCQS2Q .

MilanPutnik commented 3 years ago

Just dropped by and wanted to say that you actually have (literally) a whole fanbase of at least 50 IT professionals and esports players - who use this small addon since its inception, across various CPU platforms that came along, trough all of the W10 iterations...up until now. :-) We all would love to see an update from you - at least a symbolic zero point one. ;-P Stay well and all the best !

petrroll commented 3 years ago

Hi, @MilanPutnik thanks for the kind words! I'll think about it :).