Closed objecttothis closed 3 years ago
Hi! First off, amazing work! Happy to see that my code is still useful after all this time. And super-happy to see this high-quality contribution. Unfortunately, I'll not be merging the PR at this moment, mainly for two reasons.
1) If I were to create a new version, there are many things that should also be updated. Among other things the fly-out logic deserves an upgrade, ideally to whatever ear-trumpet is currently using, the tray-icon/menu logic should be updated, support for light theme should be added, move to .NET Core should happen, move to the modern support for packaging apps should happen, ... .
2) Even if I were ok creating a new version without 1) my whole deploy pipeline is not working right now. And for reasons outlined in #23 I can't justify spending time on it. There's a chance I might have some time during summer to properly update this project as vacations are unlikely to happen (thanks covid) but can't and don't want to promise anything.
Given I won't be merging this change (despite it being super cool and good quality) into master. If someone wants to build their own version with your update they can just just clone your fork and build it locally.
Alternatively, I'd be happy to create a separate branch for this feature on this repo and you can merge into that one. I'll remember to keep it in sync with master if I ever come back to developing this.
Or, I'm also perfectly fine with you creating proper fork and even releasing it to Windows store.
I hope you understand. :)
Hi! First off, amazing work! Happy to see that my code is still useful after all this time. And super-happy to see this high-quality contribution. Unfortunately, I'll not be merging the PR at this moment, mainly for two reasons.
1. If I were to create a new version, there are many things that should also be updated. Among other things the fly-out logic deserves an upgrade, ideally to whatever ear-trumpet is currently using, the tray-icon/menu logic should be updated, support for light theme should be added, move to .NET Core should happen, move to the modern support for packaging apps should happen, ... .
I completely understand. With my own work, I'm always finding things that I wish I could figure out how to clone myself over and work on.
2. Even if I were ok creating a new version without 1) my whole deploy pipeline is not working right now. And for reasons outlined in #23 I can't justify spending time on it. There's a chance I might have some time during summer to properly update this project as vacations are unlikely to happen (thanks covid) but can't and don't want to promise anything.
I understand. I saw that it had not been in development for some time, so I knew there was a chance that it would be an exercise in learning. I was feeling inspired to code on a non-work project at the time.
Given I won't be merging this change (despite it being super cool and good quality) into master. If someone wants to build their own version with your update they can just just clone your fork and build it locally.
Alternatively, I'd be happy to create a separate branch for this feature on this repo and you can merge into that one. I'll remember to keep it in sync with master if I ever come back to developing this.
I think at this point, I'd recommend creating a branch on this repo and merging this into that branch. That way, if you or someone else ever picks the project back up, they can use the functionality if they want...
Or, I'm also perfectly fine with you creating proper fork and even releasing it to Windows store.
I hope you understand. :)
Thanks for taking the time to look at the PR.
I think at this point, I'd recommend creating a branch on this repo and merging this into that branch. That way, if you or someone else ever picks the project back up, they can use the functionality if they want...
Did just that :)