search

petrvanblokland / TYPETR-Bitcount

Bitcount VF
SIL Open Font License 1.1
3 stars 1 forks source link

`fvar` and `STAT` tables instances reported Fails #11

Closed vv-monsalve closed 4 months ago

vv-monsalve commented 4 months ago

FAIL fvar instances are incorrect. Add missing instances

The fonts fvar instance coordinates comply with our guidelines

vv-monsalve commented 4 months ago

FAIL STAT table is missing Axis Value Records. Add missing values.

The fonts STAT instance coordinates comply with our guidelines

petrvanblokland commented 4 months ago

What should be the exact writing of instance style names? Weight as number or name? slnt as '' or 'Italic" What about the other axes?

On Apr 3, 2024, at 00:17, Viviana Monsalve @.***> wrote:

FAIL fvar instances are incorrect. Add missing instances

The fonts fvar instance coordinates comply with our guidelines https://googlefonts.github.io/gf-guide/variable.html#fvar-instances — Reply to this email directly, view it on GitHub https://github.com/petrvanblokland/TYPETR-Bitcount/issues/11, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC4DQMBNMO5F4EIYIJABSLY3MU77AVCNFSM6AAAAABFUF67Y6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZDCNJVGM2TMNY. You are receiving this because you are subscribed to this thread.

Petr van Blokland Mastodon @. Instagram @petrvanblokland Intentionally not on FaceBook since 1990 and Xwitter stopped. @. | designdesign.space | typetr.com mobile +31 6 24 219 502

Claudia Mens | @.*** mobile +31 6 41 367 689

Rotterdamseweg 150-d 2628 AP Delft The Netherlands

petrvanblokland commented 4 months ago

This code will generate the design space XML for the instances.

for wght, weightName in sorted(weightInstances.items()):
    # minValue is the same as default
    for ELXP in (ELXP_MIN, ELXP_MAX):
        # minValue is the same as default
        for ELSH in SHAPES:
            # minValue is the same as default
            for slnt in (SLNT_MIN, SLNT_MAX):
                wName = weightName
                if slnt == SLNT_MAX:
                    wName += ' Italic'
                axisParams['instances'] += f"""

    <instance familyname="Bitcount {variant} {stem}" 
        name="Bitcount {variant} {stem}" 
        stylename="wght {wName} ELXP {ELXP} ELSH{ELSH} slnt{slnt}">  <------------ It needs a style name here is will be shown in the menu?
        <location>
            <dimension name="Weight" xvalue="{wght}"/>
            <dimension name="Element Expansion" xvalue="{ELXP}"/>
            <dimension name="Element Shape" xvalue="{ELSH}"/>
            <dimension name="Slant" xvalue="{slnt}"/>
        </location>
    </instance>
        """

On Apr 3, 2024, at 18:58, Petr van Blokland @.***> wrote:

What should be the exact writing of instance style names? Weight as number or name? slnt as '' or 'Italic" What about the other axes?

On Apr 3, 2024, at 00:17, Viviana Monsalve @.***> wrote:

FAIL fvar instances are incorrect. Add missing instances

The fonts fvar instance coordinates comply with our guidelines https://googlefonts.github.io/gf-guide/variable.html#fvar-instances — Reply to this email directly, view it on GitHub https://github.com/petrvanblokland/TYPETR-Bitcount/issues/11, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC4DQMBNMO5F4EIYIJABSLY3MU77AVCNFSM6AAAAABFUF67Y6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZDCNJVGM2TMNY. You are receiving this because you are subscribed to this thread.

Petr van Blokland Mastodon @. Instagram @petrvanblokland Intentionally not on FaceBook since 1990 and Xwitter stopped. @. | designdesign.space | typetr.com mobile +31 6 24 219 502

Claudia Mens | @.*** mobile +31 6 41 367 689

Rotterdamseweg 150-d 2628 AP Delft The Netherlands

Petr van Blokland Mastodon @. Instagram @petrvanblokland Intentionally not on FaceBook since 1990 and Xwitter stopped. @. | designdesign.space | typetr.com mobile +31 6 24 219 502

Claudia Mens | @.*** mobile +31 6 41 367 689

Rotterdamseweg 150-d 2628 AP Delft The Netherlands

vv-monsalve commented 4 months ago

What should be the exact writing of instance style names? Weight as number or name?

Names and numbers.

What about the other axes?

Only weight and italic instances are allowed in the fvar table.

You could read all the details in the guidelines linked above.

simoncozens commented 4 months ago

Instances are fixed. We can't produce a compliant STAT table until the new axes are merged...

vv-monsalve commented 4 months ago

We can't produce a compliant STAT table until the new axes are merged

It's possible to add the STAT despite receiving the FB fail. We merge the axes at approximately the same time we merge the font so they navigate simultaneously (with the context of the font) through the pipeline.

simoncozens commented 4 months ago

Ah, OK, I was planning on using gftools-add-stat (without a config file) which requires the axes to be in the repository. I'll try coming up with a stat.yaml.

simoncozens commented 4 months ago

I think I've got it as good as I can. Only STAT-related FB fail is:

On the font variation axis 'slnt', the name 'Slanted' is not among the expected ones (Default) according to the Google Fonts Axis Registry.

I don't want to call the slnt=-8 value "Default" because we need to distinguish between upright and italic instances, I can't call it italic because that causes another fontbakery fail, so I think I have to called it Slanted.

vv-monsalve commented 4 months ago

A few different things:

simoncozens commented 4 months ago

OK, I can change the slnt axis mapping to "Oblique".

Now, per https://github.com/petrvanblokland/TYPETR-Bitcount/issues/8#issuecomment-2046133774 on the Axes definitions issue, these fonts are intended to be published with actual italics, so we should probably have separate Roman and Italics VFs

The italic forms are available via a stylistic set (+ss08). So I could create an italic VF by "freezing" this feature - is that what you mean?

vv-monsalve commented 4 months ago

I think so. But perhaps @petrvanblokland should confirm that there would be more than that to produce the Italic style.

Pter said there is also the option to serve the Oblique version, but the separate font files are necessary to make the Italics available to the users from the Catalog. This will also reduce one axis from the VFs, hopefully impacting the file size, which, for these fonts, any reduction that could lead to the fonts' performance improvement will be desired.

petrvanblokland commented 4 months ago

On Apr 10, 2024, at 17:22, Viviana Monsalve @.***> wrote:

A few different things:

FB is complaining because it relies on the "fallback" positions defined for each axis in the axisregistry. However, slant and the custom axes are registered without them after the eng team realized this was causing overpopulated fallback static fonts. While it's possible to use Slanted, we have been using Oblique for these cases. Now, per Petr comment https://github.com/petrvanblokland/TYPETR-Bitcount/issues/8#issuecomment-2046133774 on the Axes definitions issue, these fonts are intended to be published with actual italics, so we should probably have separate Romand and Italics VFs There is 2 situations in the font:

  • Each glyph has a slanted version (in the axis, either slnt or ital).
  • Each glyph where the italic shape is different from the roman shape (as in two story and one story /a, etc.) there is a real italic shape, selected by SS08, below shown as respectively with/without SS08 and with/wirthout slant. And alternative /g is under SS09. So there are 4 states, regarding slant/italic  I'm fine if it works better to call it Oblique, if that's a way to keep them in one font, since intermediate angles are just as much part of the design space. But it would also be good if the cmd-I indeed shows the slanted/oblique variant of the axis.

(There is a lot more that can be selected by stylistic sits, such as condensed for the Single and extended ascenders and descenders in the Mono. But the ranges of possible sets entirely depends on what is possible in the grid size of Grid, Mono and Prop, Double and Single flavors)

P

— Reply to this email directly, view it on GitHub https://github.com/petrvanblokland/TYPETR-Bitcount/issues/11#issuecomment-2047845007, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC4DQL33327I2TEKJMW4HTY4VKKHAVCNFSM6AAAAABFUF67Y6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBXHA2DKMBQG4. You are receiving this because you were mentioned.

Petr van Blokland Mastodon @. Instagram @petrvanblokland Intentionally not on FaceBook since 1990 and Xwitter stopped. @. | designdesign.space | typetr.com mobile +31 6 24 219 502

Claudia Mens | @.*** mobile +31 6 41 367 689

Rotterdamseweg 150-d 2628 AP Delft The Netherlands

simoncozens commented 4 months ago

I've made the ss08 stylistic set into a CRSV (Cursive) axis, similar to what we did for Recursive.

vv-monsalve commented 4 months ago

We discussed the options for the project and decided to go with slnt + CRSV as in Geologica.

davelab6 commented 4 months ago

Sounds good to me, thanks Viviana for the idea and Simon for making it work :)