petrvanblokland / TYPETR-Bitcount

Bitcount VF
SIL Open Font License 1.1
3 stars 1 forks source link

FAIL: Check tabular widths don't have kerning. #16

Open vv-monsalve opened 6 months ago

vv-monsalve commented 6 months ago
🔥 FAIL: Check tabular widths don't have kerning. (com.google.fonts/check/tabular_kerning)
* 🔥 **FAIL** Kerning between zero and T is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between two and T is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between three and T is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between four and T is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between five and T is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between eight and T is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between nine and T is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between zero and Tcedilla is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between two and Tcedilla is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between three and Tcedilla is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between four and Tcedilla is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between five and Tcedilla is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between eight and Tcedilla is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between nine and Tcedilla is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between zero and Tcaron is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between two and Tcaron is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between three and Tcaron is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between four and Tcaron is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between five and Tcaron is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between eight and Tcaron is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between nine and Tcaron is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between zero and Tcommaaccent is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between two and Tcommaaccent is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between three and Tcommaaccent is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between four and Tcommaaccent is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between five and Tcommaaccent is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between eight and Tcommaaccent is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between nine and Tcommaaccent is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between two and Z is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between five and Z is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between two and Zacute is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between five and Zacute is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between two and Zdotaccent is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between five and Zdotaccent is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between two and Zcaron is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between five and Zcaron is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between zero and Tbar is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between two and Tbar is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between three and Tbar is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between four and Tbar is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between five and Tbar is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between eight and Tbar is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between nine and Tbar is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between four and seven is not zero [code: has-tabular-kerning]

This Fail is reported for two of the new fonts in the CI run.

petrvanblokland commented 6 months ago

Solved

On Apr 12, 2024, at 02:13, Viviana Monsalve @.***> wrote:

🔥 FAIL: Check tabular widths don't have kerning. (com.google.fonts/check/tabular_kerning https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/universal.html#com.google.fonts/check/tabular_kerning) This Fail is reported for two of the new fonts in the CI run https://github.com/petrvanblokland/TYPETR-Bitcount/actions/runs/8650173142/artifacts/1405875842.

BitcountPropSingle[CRSV,ELSH,ELXP,SZP1,SZP2,XPN1,XPN2,YPN1,YPN2,slnt,wght].ttf BitcountPropSingle[CRSV,ELSH,ELXP,slnt,wght].ttf — Reply to this email directly, view it on GitHub https://github.com/petrvanblokland/TYPETR-Bitcount/issues/16, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC4DQLT6TAW5AW7XHZO6FDY44RK5AVCNFSM6AAAAABGDGLXRSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZTQOBQGQ4TSMI. You are receiving this because you are subscribed to this thread.


Petr van Blokland Mastodon @. Instagram @petrvanblokland Intentionally not on FaceBook since 1990 and Xwitter stopped. @. | designdesign.space | typetr.com mobile +31 6 24 219 502

Claudia Mens | @.*** mobile +31 6 41 367 689

Rotterdamseweg 150-d 2628 AP Delft The Netherlands

vv-monsalve commented 6 months ago

After downloading the latest font from the CI build at commit 806c71d. There are still some cases reported.

🔥 FAIL: Check tabular widths don't have kerning. (com.google.fonts/check/tabular_kerning)
* 🔥 **FAIL** Kerning between zero and T is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between four and T is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between zero and Tcedilla is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between four and Tcedilla is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between zero and Tcaron is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between four and Tcaron is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between zero and Tcommaaccent is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between four and Tcommaaccent is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between zero and Tbar is not zero [code: has-tabular-kerning] * 🔥 **FAIL** Kerning between four and Tbar is not zero [code: has-tabular-kerning]
petrvanblokland commented 6 months ago

Strange, I fixed that all. I'll check why it was not committed obviously.

On Apr 17, 2024, at 00:13, Viviana Monsalve @.***> wrote:

After downloading the latest font from the CI build at commit 806c71d. There are still some cases reported.

🔥 FAIL: Check tabular widths don't have kerning. (com.google.fonts/check/tabular_kerning https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/universal.html#com.google.fonts/check/tabular_kerning) — Reply to this email directly, view it on GitHub https://github.com/petrvanblokland/TYPETR-Bitcount/issues/16#issuecomment-2060001416, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC4DQNXN2IGC2JGEG4FBUDY5WO7BAVCNFSM6AAAAABGDGLXRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRQGAYDCNBRGY. You are receiving this because you were mentioned.


Petr van Blokland Mastodon @. Instagram @petrvanblokland Intentionally not on FaceBook since 1990 and Xwitter stopped. @. | designdesign.space | typetr.com mobile +31 6 24 219 502

Claudia Mens | @.*** mobile +31 6 41 367 689

Rotterdamseweg 150-d 2628 AP Delft The Netherlands

petrvanblokland commented 6 months ago

I can 't find any of these kerning pairs in the version that was committed last. Is the script really building the UFO's from scratch? Otherwise there's still kerning in the in intermediate UFO files.

On Apr 17, 2024, at 00:13, Viviana Monsalve @.***> wrote:

After downloading the latest font from the CI build at commit 806c71d. There are still some cases reported.

🔥 FAIL: Check tabular widths don't have kerning. (com.google.fonts/check/tabular_kerning https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/universal.html#com.google.fonts/check/tabular_kerning) — Reply to this email directly, view it on GitHub https://github.com/petrvanblokland/TYPETR-Bitcount/issues/16#issuecomment-2060001416, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC4DQNXN2IGC2JGEG4FBUDY5WO7BAVCNFSM6AAAAABGDGLXRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRQGAYDCNBRGY. You are receiving this because you were mentioned.


Petr van Blokland Mastodon @. Instagram @petrvanblokland Intentionally not on FaceBook since 1990 and Xwitter stopped. @. | designdesign.space | typetr.com mobile +31 6 24 219 502

Claudia Mens | @.*** mobile +31 6 41 367 689

Rotterdamseweg 150-d 2628 AP Delft The Netherlands