petrvanblokland / TYPETR-Bitcount

Bitcount VF
SIL Open Font License 1.1
3 stars 1 forks source link

FAIL: Check font family names are correct #18

Open vv-monsalve opened 2 months ago

vv-monsalve commented 2 months ago
πŸ”₯ FAIL: Check font names are correct (com.google.fonts/check/font_names)
* πŸ”₯ **FAIL** Font names are incorrect: | nameID | current | expected | | :--- | :--- | :--- | | Family Name | **BitcountGridSingle** | **Bitcount Grid Single** | | Subfamily Name | Regular | Regular | | Full Name | Bitcount Grid Single Regular | Bitcount Grid Single Regular | | Postscript Name | BitcountGridSingle-Regular | BitcountGridSingle-Regular | | Typographic Family Name | **Bitcount Grid Single** | **N/A** | [code: bad-names]
πŸ”₯ FAIL: Check that OS/2.fsSelection bold & italic settings are unique for each NameID1 (com.adobe.fonts/check/family/bold_italic_unique_for_nameid1)
* πŸ”₯ **FAIL** Family 'BitcountGridSingle' has 2 fonts (should be no more than 1) with the same OS/2.fsSelection bold & italic settings: Bold=False, Italic=False [code: unique-fsselection] * πŸ”₯ **FAIL** Family 'BitcountPropSingle' has 2 fonts (should be no more than 1) with the same OS/2.fsSelection bold & italic settings: Bold=False, Italic=False [code: unique-fsselection] * πŸ”₯ **FAIL** Family 'BitcountMonoSingle' has 2 fonts (should be no more than 1) with the same OS/2.fsSelection bold & italic settings: Bold=False, Italic=False [code: unique-fsselection] * πŸ”₯ **FAIL** Family 'Bitcount' has 2 fonts (should be no more than 1) with the same OS/2.fsSelection bold & italic settings: Bold=False, Italic=False [code: unique-fsselection] * πŸ”₯ **FAIL** Family 'BitcountGridDouble' has 2 fonts (should be no more than 1) with the same OS/2.fsSelection bold & italic settings: Bold=False, Italic=False [code: unique-fsselection] * πŸ”₯ **FAIL** Family 'BitcountPropDouble' has 2 fonts (should be no more than 1) with the same OS/2.fsSelection bold & italic settings: Bold=False, Italic=False [code: unique-fsselection]

There are a combination of issues happening with font names:

vv-monsalve commented 1 month ago

@petrvanblokland The family Name (name ID 1) of BitcountGridSingle[CRSV,ELSH,ELXP,SZP1,SZP2,XPN1,XPN2,YPN1,YPN2,slnt,wght].ttf must include a reference that it is the colored font. Under the current name schema the suggested is Ink, so

vv-monsalve commented 2 weeks ago

The above Fails are still reported for the fonts included in the action run at commit 379ff71.

E.g.

  • The nameID 1 should keep the spaces between the words. E.g. Bitcount Grid Single
Screen Shot 2024-08-08 at 17 35 41