petrvanblokland / TYPETR-Bitcount

Bitcount VF
SIL Open Font License 1.1
3 stars 1 forks source link

Fontbakery fixes #24

Closed simoncozens closed 1 month ago

simoncozens commented 2 months ago
petrvanblokland commented 2 months ago

TPTR should be a registered verdor ID.

Dave: as a set of floating diacritics is proposed to be added, the main glyphs also need anchors. So far Bitcount did not have support for floating accents. Is there a (standard) list on your side of glyphs that require top and bottom anchors to accommodate the new diacritics?

P

On Jun 18, 2024, at 09:07, Simon Cozens @.***> wrote:

Fix MVAR/HVAR error with new paintcompiler Skip long outline checks Correct vendor ID You can view, comment on, or merge this pull request online at:

https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24

Commit Summary

dd7311a https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24/commits/dd7311ab76f0a79c19d2dcb1aaa2f29c1a2e335d Fix MVAR/HVAR error with new paintcompiler ecca251 https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24/commits/ecca2518d7b0fb9447815e51f544f58e1a5b781d Skip long outline checks b78eca8 https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24/commits/b78eca8a4e0108cb67a18ea1af888e74eec731cd Correct vendor ID File Changes (15 files https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24/files) M fontbakery.toml https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24/files#diff-a32d9f1b5ea8bd1effa6c098c3ae0fba3cb6dea67a61ef467b62f5818ef7a294 (6) M requirements.txt https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24/files#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552 (2) M scriptsLib/colrv1.py https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24/files#diff-967274a9cf0a69954fbddaa3be927ad4416203b4d07d9efea6e04e9a1369c059 (10) M sources/ufo/Bitcount_Grid_Double-Italic.ufo/fontinfo.plist https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24/files#diff-0c7bf6a3254c9e43104121c7e3b819ad3999910ae388de1a04c1c0ec78f6ce81 (2) M sources/ufo/Bitcount_Grid_Double.ufo/fontinfo.plist https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24/files#diff-5f8b7d1bf5f9b9ca37a55f3a575fdf41d5d5e508c1387102115c76c203247fc5 (2) M sources/ufo/Bitcount_Grid_Single-Italic.ufo/fontinfo.plist https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24/files#diff-b2fbe8aeb2947abdfe2b6e44abb7ccdb3c52ec946440e8c6102c07238df06631 (2) M sources/ufo/Bitcount_Grid_Single.ufo/fontinfo.plist https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24/files#diff-edf797a48c240aec301db9419442ff61f35a5878b138b599ba371cffee5146d3 (2) M sources/ufo/Bitcount_Mono_Double-Italic.ufo/fontinfo.plist https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24/files#diff-d0e666a82f45f939d8675e1835e6560ee18895927264405af8eaa0e5acbb7055 (2) M sources/ufo/Bitcount_Mono_Double.ufo/fontinfo.plist https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24/files#diff-be81d45c4891aca10c652977108a8adbd3a4a68cb7fbb04e5d67732f580d4fcf (2) M sources/ufo/Bitcount_Mono_Single-Italic.ufo/fontinfo.plist https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24/files#diff-5b899abd4226080c8db57333baf19df6dbd470c5cce5f95554f17980cb284c63 (2) M sources/ufo/Bitcount_Mono_Single.ufo/fontinfo.plist https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24/files#diff-de66787d68904fdec09571bc692f9cf299c1ad231fad172d1dd265c5c61f876e (2) M sources/ufo/Bitcount_Prop_Double-Italic.ufo/fontinfo.plist https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24/files#diff-ed35f420264acc485861c27daf3d7ffe43f82a433c3cc3301f9adc02793f0265 (2) M sources/ufo/Bitcount_Prop_Double.ufo/fontinfo.plist https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24/files#diff-4db99805976f1b2a0bfcfa3f115820f1d75d1add79e6371ec0f0eebaebd109b5 (2) M sources/ufo/Bitcount_Prop_Single-Italic.ufo/fontinfo.plist https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24/files#diff-94bd73b7b6cef0a99bfd6e9e6c88c646b6654ae5e5fcd9b2e8f67f7b967ae4c2 (2) M sources/ufo/Bitcount_Prop_Single.ufo/fontinfo.plist https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24/files#diff-ebcc34e78b783b01a9c24c2534feb66a5d6fbbaaec9d60f1e8206884fed40863 (2) Patch Links:

https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24.patch https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24.diff — Reply to this email directly, view it on GitHub https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC4DQKCNCFUPCBIOO7HMR3ZIAWIDAVCNFSM6AAAAABJQADBV6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2TSOBSGQ3TKNQ. You are receiving this because you are subscribed to this thread.


Petr van Blokland Mastodon @. Instagram @petrvanblokland Intentionally not on FaceBook since 1990 and Xwitter stopped. @. | designdesign.space | typetr.com mobile +31 6 24 219 502

Claudia Mens | @.*** mobile +31 6 41 367 689

Rotterdamseweg 150-d 2628 AP Delft The Netherlands

simoncozens commented 2 months ago

TPTR should be a registered verdor ID.

Ah, so it is. You had petr. I'll fix again.

Is there a (standard) list on your side of glyphs that require top and bottom anchors to accommodate the new diacritics?

The fontbakery report tells you which glyphs need this, but only once the combining marks are added.

petrvanblokland commented 2 months ago

On Jun 18, 2024, at 11:27, Simon Cozens @.***> wrote:

TPTR should be a registered verdor ID.

Ah, so it is. You had petr. I'll fix again.

Hm, yes, The Bitcount files are much older than when I got TPTR registered. Good find.

Is there a (standard) list on your side of glyphs that require top and bottom anchors to accommodate the new diacritics?

The fontbakery report tells you which glyphs need this, but only once the combining marks are added.

Ok, I'll add them first.

— Reply to this email directly, view it on GitHub https://github.com/petrvanblokland/TYPETR-Bitcount/pull/24#issuecomment-2176382986, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC4DQIKMAC74QKBA3MFKPDZIBGWBAVCNFSM6AAAAABJQADBV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZWGM4DEOJYGY. You are receiving this because you were mentioned.


Petr van Blokland Mastodon @. Instagram @petrvanblokland Intentionally not on FaceBook since 1990 and Xwitter stopped. @. | designdesign.space | typetr.com mobile +31 6 24 219 502

Claudia Mens | @.*** mobile +31 6 41 367 689

Rotterdamseweg 150-d 2628 AP Delft The Netherlands

simoncozens commented 1 month ago

I'm going to merge these because they are improvements, but we are still waiting on the combining marks.