petschau / WinFellow

WinFellow
https://petschau.github.io/WinFellow/
GNU General Public License v2.0
88 stars 13 forks source link

Configuration file issue with graphics driver #131

Closed petschau closed 11 months ago

petschau commented 11 months ago

Recreate: The emulator is executed with a blank/default configuration (ie. there is no last used configuration). Then load a configuration file from the menu. The emulator will not switch to the graphics driver from the loaded config unless the configuration dialog is opened and closed before starting to emulate. The emulator should switch graphics driver after loading the configuration file.

petschau commented 11 months ago

The configured and actual graphics driver in use could get out of sync by certain UI actions. There was a similar scenario when a user makes graphics driver changes and cancels them. Fixed from the UI for now for the situations where it can happen.

The underlying problem is that the graphics driver config property is the only one that gets applied on the fly in the UI and as such must be restored on cancel action and handled as an exception in some other cases. The UI does this to obtain resolution info. A more fundamental (but larger) fix would be to look at a different way to give this info to the UI that does not immediately apply the configuration change.

Also found and fixed a minor UI mismatch with diskimage names on the main UI after cancel.