search

petterreinholdtsen / battery-stats

Log battery charge (battery-stats-collector), show gnuplot graphs (battery-graph)
GNU General Public License v2.0
27 stars 13 forks source link

Adds colors to battery-graph gnuplot output and some discharge rate fitting #16

Closed fzenke closed 8 years ago

fzenke commented 8 years ago

This pull request had gone stale somehow with krf. I just rebased my changes onto your fork. Maybe you find some of it useful. Cheers! F

petterreinholdtsen commented 8 years ago

It would be easier to accept this patch if you split in into one pull request per feature, instead of having several independent changes in one pull request.

fzenke commented 8 years ago

I agree. I can submit an amended pull request with these changes squashed. Might take a week or so before I will get to this though.

On 04/14/2016 10:15 PM, petterreinholdtsen wrote:

It would be easier to accept this patch if you split in into one pull request per feature, instead of having several independent changes in one pull request.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/petterreinholdtsen/battery-stats/pull/16#issuecomment-210289920

fzenke commented 8 years ago

Created two separate pull requests for color and the line fit. It's still a bit messy because some fixes for the color feature are in the fit pull-request because this was the evolution of the things and I did not wont to redo all changes. Also added the mktemp instead of my homebrew version. Hope you find it helpful.