petushka1
commented
2 years ago I’m sorry I mixed up the days and applied uncomplicated project. This should be for mob menu. I apologise. I tried to cancel submission but failed.
Вт, 10 мая 2022 г. в 00:50, Yassine Omari @.***>:
@.**** requested changes on this pull request.
Hi @petushka1 https://github.com/petushka1 ,
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there! Highlights
✔️ No linter error Required Changes ♻️
Check the comments under the review. Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
if you still didn't understand the requirements please don't hesitate to mention me in the comments or reach out to me on slack
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In script.js https://github.com/petushka1/microverse-m1-w1-d3-portfolio-production/pull/11#discussion_r868498944 :
+function opened() {
- div.style.display = 'block';
+}
+
+function closed() {
- div.style.display = 'none';
+}
+
+div.className = 'extended';
+
+img.className = 'icon';
+img.src = './img/close.svg';
+div.appendChild(img);
+img.addEventListener('click', closed);
+
+ul.className = 'menu-extended';
+div.appendChild(ul);
+
+a.href = '#about';
-
I think there is a misunderstanding here you should make the project cards generated dynamically using Javascript by storing projects information in an array and display that each project information and in more detail when the user click on the See the project button
project card [image: image] https://user-images.githubusercontent.com/61790587/167504112-ee50562d-5b9e-4fa4-b997-57c0a190aee1.png
window popup for more detail [image: image] https://user-images.githubusercontent.com/61790587/167504170-67fc4d48-f8ea-4aba-8e46-f68beca53d52.png
and don't forget the design for mobile also
— Reply to this email directly, view it on GitHub https://github.com/petushka1/microverse-m1-w1-d3-portfolio-production/pull/11#pullrequestreview-966865641, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKWIJY4T3PKNK7MTVOBGEN3VJGCCDANCNFSM5VPM7PQA . You are receiving this because you were mentioned.Message ID: <petushka1/microverse-m1-w1-d3-portfolio-production/pull/11/review/966865641 @github.com>
-- Sincerely, Nadezhda Levina
youmari
Work completed: