petushka1 / microverse-m1-w1-d3-portfolio-production

MIT License
0 stars 0 forks source link

Popup and Dynamic Project Section #13

Closed petushka1 closed 2 years ago

petushka1 commented 2 years ago
petushka1 commented 2 years ago

Hello. If you check js everything is created dynamically and generated through DOM. Also, I'd ask you to be more specific about [OPTIONAL] edits on README. I didn't notice misspellings, sorry. Thanks for your input.

Ismailco commented 2 years ago

Hi @petushka1,

petushka1 commented 2 years ago

Thank you so much! Missed this Пт, 13 мая 2022 г. в 13:22, Makungong Collins @.***>:

@.**** commented on this pull request.

In script.js https://github.com/petushka1/microverse-m1-w1-d3-portfolio-production/pull/13#discussion_r872228631 :

  • function openPopup(e) {
  • const j = e.target.id;
  • const popup = document.createElement('div');
  • popup.className = 'popup';
  • wrapper.appendChild(popup);
  • function closePopup() {
  • popup.style.display = 'none';
  • }
  • const popupContent = document.createElement('div');
  • popupContent.className = 'popupContent fontSmall';
  • popup.appendChild(popupContent);
  • img = document.createElement('img');
  • img.src = 'img/closeDark.svg';

Yeah Change the image directory (folder) name in your code from img to Img

— Reply to this email directly, view it on GitHub https://github.com/petushka1/microverse-m1-w1-d3-portfolio-production/pull/13#discussion_r872228631, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKWIJY32EHKHYLKHXE27NQDVJYUPVANCNFSM5VZTF6RQ . You are receiving this because you modified the open/close state.Message ID: <petushka1/microverse-m1-w1-d3-portfolio-production/pull/13/review/972050313 @github.com>

-- Sincerely, Nadezhda Levina