petyosi / react-virtuoso

The most powerful virtual list component for React
https://virtuoso.dev
MIT License
5.25k stars 301 forks source link

Latest version (0.12.0) broken #43

Closed yhnavein closed 4 years ago

yhnavein commented 5 years ago

When upgraded to the latest version (0.12.0), my app is not buildable by TypeScript because of the following error:

TypeScript error in app/node_modules/react-virtuoso/dist/Virtuoso.d.ts(2,29):
Cannot find module 'tinyrx'.  TS2307

    1 | import React, { CSSProperties, FC, PureComponent, ReactElement } from 'react';
  > 2 | import { TSubscriber } from 'tinyrx';
      |                             ^
    3 | import { TScrollLocation } from './EngineCommons';
    4 | import { ListItem } from './GroupIndexTransposer';
    5 | import { TRender, TRenderProps } from './VirtuosoList';

I can see that react-virtuoso does not refer to the tinyrx as its dependency.

yhnavein commented 5 years ago

And it seems that the same error appears in the version 0.11.1 Version 0.10.2 works fine

petyosi commented 5 years ago

👍 Thanks for reporting this, fixed the import in 0.12.1, let me know if it works for you.

Cheers,

EdwardSalter commented 4 years ago

I am seeing this exact issue with the latest version (0.17.4) also whilst using TypeScript.

TypeScript error in C:/dev/,myapp/node_modules/react-virtuoso/dist/VirtuosoGrid.d.ts(2,29):
Cannot find module 'tinyrx' or its corresponding type declarations.  TS2307

    1 | import React, { CSSProperties, ReactElement } from 'react';
  > 2 | import { TSubscriber } from 'tinyrx';
petyosi commented 4 years ago

@EdwardSalter - sorry about that, should be fixed in 0.17.5.

EdwardSalter commented 4 years ago

@petyosi - Thank you for that. Do you have an estimate on when that will be released?

EDIT: I have updated and all is right with the world again. Many thanks for the very quick turnaround! 👍