search

petyosi / react-virtuoso

The most powerful virtual list component for React
https://virtuoso.dev
MIT License
5.16k stars 299 forks source link

feat: added table-state #983

Closed ru-van-urk closed 12 months ago

ru-van-urk commented 12 months ago

I noticed that the table docs mentioned restoreStateFrom but this feature is not implemented. This pull request adds that functionality. If there is more to be done I will happily do so. I tested the functionality in table-state.tsx.

Also whilst I am working on tables. I would love to update the react-table integration documentation because the package is updated, nowadays it is tanstack table. My question is should I leave the react-table docs as is for backwards compatibility and create a seperate example called tanstack/table or should I replace it alltogether?

petyosi commented 12 months ago

Lovely! I will test the PR and merge it if everything goes ok.

re: react-table example. Yes, please go ahead. I'm happy to accept a PR on the matter. I am not an user of the react-table/tanstack table, so I am not sure what people need there, but last time I tried to integrate it, it was quite an adventure.

petyosi commented 12 months ago

About backwards compatibility - no, no need to keep that.

github-actions[bot] commented 12 months ago

:tada: This PR is included in version 4.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: