search

pevers / images-scraper

Simple and fast scraper for Google
ISC License
225 stars 70 forks source link

Added support for google image resolution #1

Closed Elyx0 closed 8 years ago

Elyx0 commented 8 years ago

Params: resolution, Values: [l,m,i]

On another note, are you sure that Nighmare is releasing by itself all the memory/processes when done replying the results ? I'm not seeing any nightmare.teardownInstance(); or nightmare.end();

I will look into supporting more options from the image resolution options.

Google closed their deprecated public api for image searches today. So here I come!

Good job by the way!

pevers commented 8 years ago

@Elyx0 Thanks! Very good idea, I'll merge right away! :+1:

Good point on the Nightmare release, I didn't look at this problem. I'll try to solve this tonight.

EDIT: That was quite easy to solve, see update

Elyx0 commented 8 years ago

Nice, I can now use it in production from master !

timkock commented 8 years ago

Oh man such open source goodness here right before christmas, very pull, such request