`pew in` needs to exit with an error code when the command is not found

pew-org / pew

A tool to manage multiple virtual environments written in pure python

MIT License

1.17k stars 81 forks source link

`pew in` needs to exit with an error code when the command is not found #200

Closed mortenlj closed 5 years ago

mortenlj commented 5 years ago

I had a problem in my CI build, where after some refactoring we noticed that our tests were not executed, but the build succeeded anyway. The reason turns out to be that when you run pew in venv tox, and tox isn't actually installed in venv, pew prints a helpful message about not finding tox, and exits with 0.

It would be nice if pew could exit with some other code when failing to execute the command.

berdario commented 5 years ago

Yeah, that's quite annoying for it to be failing silently :/

I thought of properly relaying the exit code already some time ago, there's no good reason that wouldn't have been done already. I prepared a fix, will merge soon.

Thanks for the report!