pex-gl / pex-renderer

Physically based renderer (PBR) and scene graph for PEX.
https://pex-gl.github.io/pex-renderer/examples/index.html
MIT License
237 stars 16 forks source link

loadScene default options #203

Closed vorg closed 5 years ago

vorg commented 5 years ago

I'm creating this issue to discuss the defaults.

Should skipCameras default to true or (be replaced with includeCameras: false

Should we add skipLights defaulting to true or (be replaced with includeLights: false

Most common scenario is using glTF as asset format for meshes to be included in already existing "scene". This will be even more relevant once we add support for image based lighting as it would create situations where lights or reflection maps can leak out of the loaded model to the whole scene.

dmnsgn commented 5 years ago

Consensus = default to:

dmnsgn commented 5 years ago

Fixed in 238760148862d3c315609ed8dad18ff08deacc8a (side note: lights aren't loaded yet but I added the default options as a reminder)