Gltf colors are wrongly passed as linear

pex-gl / pex-renderer

Physically based renderer (PBR) and scene graph for PEX.

https://pex-gl.github.io/pex-renderer/examples/index.html

MIT License

234 stars 16 forks source link

Gltf colors are wrongly passed as linear #236

Closed vorg closed 5 years ago

vorg commented 5 years ago

Currently baseColorFactor and emissiveFactor, specularFactor and diffuseFactor are linear in glTF but sRGB in our shaders (as values usually come from hex codes or sliders). That means they appear darker when read from glTF.

vorg commented 5 years ago

Related: Linear Material Colors #36

vorg commented 5 years ago

This is especially visible for models without textures

Before Screenshot 2019-09-04 at 23 47 14

After Screenshot 2019-09-04 at 23 47 01