72 helpers

[vorg]

@simonharrisco Note about comment convention: please use imperative style

bbox -> Finish bbox rendering implementation add for gltf models -> Add helper to each gltf model basic bbox -> Implement basic bounding box helper draw lines on 1st camera -> Add test line rendering create example scene -> Create example helpers scene

[vorg]

I would use different color for instanced cubes as they clash with red bounding box

[dmnsgn]

Can we use getAxesPositions or something more accurate than makeAxes as well? We never use the make convention anywhere else.

[simonharrisco]

It also seems a little strange that orthographic 'zoom' a higher number means zoomed out. Could just be some bias I have though

[simonharrisco]

Adds helpers for:

• Point Lights
• Directional Lights
• Spot Lights
• Area Lights
• Axis
• Floor grid
• Perspective Camera
• Orthographic Camera

Removes helpers.js file that was being used in other example files, (replaces functionality)

Comments / Questions:

• A review of structure could be nice as it could probably be improved, not sure the best way to do it though
• Some othographic camera questions are above
• At the moment the axis helper is all one color, is there an industry standard for the color of x,y,z? It also shows at world [0,0,0] not the origin of the current entity. Im not sure if this is desired behaviour or not
• Floor grid is currently 1m squares, should this be customisable?
• What is desired behaviour for helper if a light is in the scene as an entity but the light itself is disabled? Currently it shows the helper so long as the entity exists in the scene.
• Currently the draw command and the vertex buffers are are properties of the renderer object

[vorg]

• as long as those are only 3 props (buffers+ cmd) it’s ok. What’s not ok is drawing code in the renderer. It should be axisHelper.draw(geomBuilder).
• what about ortho scale instead of zoom? How other engines call it?
• xyz are usually colored rgb :)
• 1m is good default. 30m size is a bit arbitrary 10m would be better. Both size and step should be configurable
• what other engines do for disabled entity helpers? There are 2 options: hide or show at 50% opacity. I would hide.

[dmnsgn]

It also seems a little strange that orthographic 'zoom' a higher number means zoomed out. Could just be some bias I have though

Zoom should be interpreted as size multiplier of camera view planes as we are not using a perspective projection.

Other engines:

• Three: zoom
• Unity: orthoSize
• Babylon: 🤷‍♂️ setting camera.orthoXXX
• Blender: orthographic scale

[vorg]

What is the purpose of it though? Why would i set ortho -1,1 and zoom 2 instead of ortho -2,2?

[dmnsgn]

For the orbiter I think?