search

pex-gl / pex-renderer

Physically based renderer (PBR) and scene graph for PEX.
https://pex-gl.github.io/pex-renderer/examples/index.html
MIT License
234 stars 16 forks source link

Consider removing Signals #248

Closed vorg closed 1 year ago

vorg commented 4 years ago

Signal.dispatch generates junk every frame by calling Array.prototype.slice.call(arguments) which contributes to GC.

Any real use case where they are still needed?

dmnsgn commented 4 years ago

I have never used it so I am in favour of removing it. Nowadays if I needed to listen for property change I would probably use Proxy getter/setter.

dmnsgn commented 1 year ago

TODO v4: remove the dependency when cleaning up components