search

pex-gl / pex-renderer

Physically based renderer (PBR) and scene graph for PEX.
https://pex-gl.github.io/pex-renderer/examples/index.html
MIT License
234 stars 16 forks source link

Instancing offset should be added after the skinning #280

Closed vorg closed 1 year ago

vorg commented 3 years ago

https://github.com/pex-gl/pex-renderer/blob/master/shaders/pipeline/material.vert.js#L120

dmnsgn commented 1 year ago

v4: We now have separate #ifdef USE_SKIN :

https://github.com/pex-gl/pex-renderer/blob/90a39cb5b751e67eb8390aacff0ccb2bbcaa81c8/systems/renderer/pex-shaders/shaders/pipeline/material.vert.js#L132

that checks offset after skinning is applied:

https://github.com/pex-gl/pex-renderer/blob/90a39cb5b751e67eb8390aacff0ccb2bbcaa81c8/systems/renderer/pex-shaders/shaders/pipeline/material.vert.js#L156-L158