search

pex-gl / pex-renderer

Physically based renderer (PBR) and scene graph for PEX.
https://pex-gl.github.io/pex-renderer/examples/index.html
MIT License
234 stars 16 forks source link

Overlay alpha property is not used #282

Closed dmnsgn closed 1 year ago

dmnsgn commented 3 years ago

https://github.com/pex-gl/pex-renderer/blob/ed823d46117089996a63fdec02a74650ba6e7cc0/overlay.js#L15

We can set the alpha component of the this.texture but it would be convenient to use the this.alpha as a multiplier.

vorg commented 3 years ago

I think it was the intention.. https://github.com/pex-gl/pex-renderer/commit/8d3e74988b6ceea6b4512428d5c7a220706f709a

Maybe i committed js but forgot to push code.

dmnsgn commented 1 year ago

TODO v4: port overlay system

vorg commented 1 year ago

Overlays not in scope for v4