search

pex-gl / pex-renderer

Physically based renderer (PBR) and scene graph for PEX.
https://pex-gl.github.io/pex-renderer/examples/index.html
MIT License
237 stars 16 forks source link

[glTF] URI-decode all URIs present in a glTF model #292

Closed dmnsgn closed 1 year ago

dmnsgn commented 3 years ago

A new sample model has been added to test URI: https://github.com/KhronosGroup/glTF-Sample-Models/tree/master/2.0/Box%20With%20Spaces

Our implementation will fail: https://github.com/pex-gl/pex-renderer/blob/18746d1869dc11c9ca2bcff1eaaad428cd9b98e7/loaders/glTF.js#L937

Fix:

url: decodeURIComponent([basePath, image.uri].join('/')),
vorg commented 3 years ago

I did have issues with spaces, so thats good catch

dmnsgn commented 1 year ago

Fixed in v4 b37f93d29c0f764b166ed70cde8a623deabdc133