Directional light entity helper should not grow with light intensity

pex-gl / pex-renderer

Physically based renderer (PBR) and scene graph for PEX.

https://pex-gl.github.io/pex-renderer/examples/index.html

MIT License

234 stars 16 forks source link

Directional light entity helper should not grow with light intensity #349

Closed vorg closed 8 months ago

vorg commented 8 months ago

Currently:

directional light: intensity -> radius
point light: intensity -> nothing
spot light: intensity -> circle radius, angle -> cone radius
area light: intensity -> nothing, scale -> rectangle size

dmnsgn commented 8 months ago

Which version are you looking at?

Currently v4 alpha has: directional light:

intensity: prism size

point light:

range: lines sticking out of prism vertices lines length
intensity: nothing, should be prism size maybe ⚠️

spot light:

intensity: cone apex circle radius
radius: cone base outer circle radius
innerRadius: cone base inner circle radius
range: cone length

area light:

intensity: lines sticking out of rectangle vertices lines length
width/height (eg. transform scale X/Y): rectangle size

I am in favour of showing intensity/range in light helpers as it helps differentiate lights and matches scene scale (bigger scene often = bigger range).

vorg commented 8 months ago

I'm looking at v4 alpha. IMO size of gizmo should be only related to range as it indicates physical distance. Directional light being prism like omni/point light is just confusing as usually quite big=strong. Maybe a quad with more and more lines sticking out if it (could work well for point light too). Will do research how others do it.

vorg commented 8 months ago

Unity