search

pex-gl / pex-renderer

Physically based renderer (PBR) and scene graph for PEX.
https://pex-gl.github.io/pex-renderer/examples/index.html
MIT License
234 stars 16 forks source link

[glTF] xmag and ymag in glTF loaders shouldn't be halved #364

Closed dmnsgn closed 4 months ago

dmnsgn commented 4 months ago

Issue:

https://github.com/pex-gl/pex-renderer/blob/16f4dc6b324045988e5484e69aecc49508ba87cf/loaders/glTF.js#L861-L864

Spec: https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html#orthographic-projection

r be half the orthographic width, set by camera.orthographic.xmag;

t be half the orthographic height, set by camera.orthographic.ymag;

Related: https://github.com/KhronosGroup/glTF/issues/1663