pex-gl / pex-renderer

Physically based renderer (PBR) and scene graph for PEX.
https://pex-gl.github.io/pex-renderer/examples/index.html
MIT License
234 stars 16 forks source link

Transmission IBL reflection color is wrong #379

Closed vorg closed 1 month ago

vorg commented 1 month ago

Reflection color should be tinted by attenuationColor but for any value outside of 1 and 0 it becomes instantly white e.g. 1,0.1,0.1 seem not to colorize reflections at all while 1,0,0 does.

Compare with three.js example where reflections are yellow on yellow dragon https://threejs.org/examples/webgl_materials_physical_transmission_alpha.html

Image

dmnsgn commented 1 month ago

Isn't that just the envmap? Using the same hdr in Dragon Atteniation model in our gltf example:

image
vorg commented 1 month ago

I think you are right and the envmap was in warm tones.

From Arnold

The color the specular reflection will be modulated with. Use this color to 'tint' the specular highlight. You should only use colored specular for certain metals, whereas non-metallic surfaces usually have a monochromatic specular color. Non-metallic surfaces normally do not have a colored specular.