pex-gl / pex-shaders

MIT License
3 stars 0 forks source link

Improve Bloom #11

Open dmnsgn opened 4 months ago

dmnsgn commented 4 months ago
vorg commented 2 months ago
dmnsgn commented 2 months ago
  • [ ] combine 8 upscale passes adding all blur steps into threshold texture into one final blend pass

Should we also add a blending mode option for this (if we want to blend with screen for instance)?

vorg commented 2 months ago

if we can make it work, then yes.

dmnsgn commented 1 month ago
vorg commented 1 month ago
vorg commented 1 month ago

Are we using Kawase technique here? Very good video on modern bloom that talks about downsampling but also upsampling instead of just blending https://www.youtube.com/watch?v=ml-5OGZC7vE

dmnsgn commented 1 month ago

Are we using Kawase technique here? Very good video on modern bloom that talks about downsampling but also upsampling instead of just blending https://www.youtube.com/watch?v=ml-5OGZC7vE

No, our downsample is 4x4 box filter (+Karis's luma weighted average). No Kuwase, no 13 taps.