search

pex-tool / pex

A tool for generating .pex (Python EXecutable) files, lock files and venvs.
https://docs.pex-tool.org/
Apache License 2.0
2.52k stars 258 forks source link

Kill unused `MANIFEST.in`. #2309

Closed jsirois closed 8 months ago

jsirois commented 8 months ago

This was no longer needed with the switch to the flit PEP-517 builder back in #826 in 2019.

jsirois commented 8 months ago

I proved this to myself with:

# Before change:
$ tox -epackage -- --no-pex --additional-format sdist --additional-format wheel
...
Built:
  dist/pex-2.1.154.tar.gz
  dist/pex-2.1.154-py2.py3-none-any.whl
...
$ mkdir -p /tmp/pex/dist
$ mv dist/* /tmp/pex/dist/

# With change:
$ git rm MANIFEST.in
rm 'MANIFEST.in'
$ tox -epackage -- --no-pex --additional-format sdist --additional-format wheel
...
Built:
  dist/pex-2.1.154.tar.gz
  dist/pex-2.1.154-py2.py3-none-any.whl
...

# ~No diff:
$ diff -u <(tar -tzf /tmp/pex/dist/pex-2.1.154.tar.gz) <(tar -tzf dist/pex-2.1.154.tar.gz)
--- /dev/fd/63  2023-12-23 12:43:00.784641472 -0800
+++ /dev/fd/62  2023-12-23 12:43:00.784641472 -0800
@@ -5,7 +5,6 @@
 pex-2.1.154/.readthedocs.yaml
 pex-2.1.154/CHANGES.md
 pex-2.1.154/LICENSE
-pex-2.1.154/MANIFEST.in
 pex-2.1.154/README.rst
 pex-2.1.154/RELEASE.rst
 pex-2.1.154/docker/base/Dockerfile

$ diff -u <(zipinfo -1 /tmp/pex/dist/pex-2.1.154-py2.py3-none-any.whl) <(zipinfo -1 dist/pex-2.1.154-py2.py3-none-any.whl)
$