search

pex-tool / pex

A tool for generating .pex (Python EXecutable) files, lock files and venvs.
https://docs.pex-tool.org/
Apache License 2.0
2.5k stars 257 forks source link

Upgrade readthedocs requirements. #2338

Closed benjyw closed 6 months ago

benjyw commented 6 months ago

Our older pins were no longer compatible with production RTD.

Fixes #2337

benjyw commented 6 months ago

I tested this by replicating the RTD build commands locally, and it seems to work.

This stops the bleeding, but I will circle back to figure out if we can pare down/eliminate this requirements file. Since RTD is opinionated about what it supports, presumably it should be able to just work with those opinions.

benjyw commented 6 months ago

Based on https://blog.readthedocs.com/defaulting-latest-build-tools/ RTD should now install the latest sphinx and sphinx_rtd_theme by default, and looking at the git history of our requirements.txt, I think those are all we care about. Looks like the other pins were to work around temporary compatibility issues, and then they started piling up on each other. So a followup PR will test that assumption (I'd like to merge this to get things working again before going down that path).