Closed cburroughs closed 6 months ago
This was a regression introduced in #2346. It looks like both allow_wheels=False
and allow_build=True
should be established by the VCSArtifactDownloadManager
before taking all other options from the user. And in the case of a --no-build --wheel
lock, there will be no VCS artifacts in the lock; thus no VCSArtifactDownloadManager
will actually be used to build the PEX and so all is well.
This is definitely a bug, but I will note a few un-needed things with the OP setup:
--wheel
: That's the default (allow wheels and allow builds).pex --wheel --no-build --lock ...
when the lock already does not admit wheels.In both cases, presumably, this is done either due to liking being explicit, which I don't fault, or some form of automation where its easier to have the pex create options be redundant to the lock create options.
The bug is triggered by using 2 instead of saying nothing, which would have acheived the same ends successfully.
Example:
With the stacktrace pointing to
pex/resolve/lock_resolver.py