search

pex-tool / pex

A tool for generating .pex (Python EXecutable) files, lock files and venvs.
https://docs.pex-tool.org/
Apache License 2.0
2.83k stars 266 forks source link

Warn when `--platform` resolves fail tag checks. #2533

Closed jsirois closed 2 months ago

jsirois commented 2 months ago

The addition of a wheel tag compatibility check to the overall post-resolve check in #2512 regressed users of abbreviated --platform in some cases by failing PEX builds that would otherwise succeed and, later, actually work at runtime. Keep the spirit of #2512 by emitting a detailed warning at build time with remediation steps instead of failing the build outright.

Fixes #2532

jsirois commented 2 months ago

@benjyw and @huonw this is FYI since 2.19.0 is a regression for Pants assuming it still supports --platform; so you'd want to stay behind or skip ahead to 2.19.1 to avoid fallout.

jsirois commented 2 months ago

@cburroughs added you FYI. Avoid Pex 2.19.0 as a --platform user.

huonw commented 2 months ago

Thanks for the alert.

FYI, although I imagine it doesn't particularly change anything on the Pex side: Pants almost doesn't use it any more, as the last use on main (in FaaS targets) is now deprecated for removal in a few releases.

jsirois commented 2 months ago

Yeah, I did that research here: https://github.com/pantsbuild/pants/pull/21425#issuecomment-2356400360 I think that deprecated FaaS use is the only one in the code base affecting end users from a search this am.