pexea12 / vue-image-lightbox

A Vue component to display an image gallery lightbox
347 stars 80 forks source link

ES5 build #48

Closed ondrej-janosik closed 5 years ago

ondrej-janosik commented 5 years ago

Hi,

can you adjust babel so this lib produces ES5 compatible build? This is a nice lib but cannot be used when an app needs to support IE11.

Thanks, Ondrej.

imcvampire commented 5 years ago

Hi @ondrej-janosik, it already produces ES5 build! What is your problem when use it on IE11?

ondrej-janosik commented 5 years ago

Are you sure? Because when I look into the distributed code, I can see object-shorthand, which is not supported by IE11.

image

imcvampire commented 5 years ago

Ah okay, thank you for the report! Let me see if I can do anything!

ondrej-janosik commented 5 years ago

If you give me permission to create a PR, I have already fixed this issue locally. @imcvampire

imcvampire commented 5 years ago

@ondrej-janosik I think you can create a PR anytime you like, you just have to fork this project and push your new code to the your repo and create a PR from it to this repo

sven-ra commented 5 years ago

@ondrej-janosik Hello! How did you fix this locally?

djvov commented 5 years ago

I have already fixed this issue locally. @imcvampire

@ondrej-janosik Hello! How did you fix this?

ondrej-janosik commented 5 years ago

Hi guys, if you use https://cli.vuejs.org/, you can use https://cli.vuejs.org/config/#transpiledependencies option. By default, babel-loader ignores all files inside node_modules. If you want to explicitly transpile this dependency with Babel, you can list it in this option. Otherwise, you can fork this library and adjust the babel settings https://github.com/pexea12/vue-image-lightbox/blob/master/.babelrc

@djvov @sven-ra

djvov commented 5 years ago

@ondrej-janosik

you can fork this library and adjust the babel settings

this works, thanks!

If you want to explicitly transpile this dependency with Babel, you can list it in this option.

which dependency I should wrote in this list?