search

peytonyip / docker-nginx-brotli

MIT License
3 stars 0 forks source link

Documentation should mention health check port #47

Closed ecker00 closed 4 months ago

ecker00 commented 4 months ago

I noticed that in recent update, it's been added a HEALTHCHECK on port 80. Documentation should probably mention to change this port if a custom port is used.

I see this new layer:

HEALTHCHECK &{["CMD-SHELL" "nc -z localhost 80 || exit 1"] "10s" "5s" "1m0s" "0s" '\x00'}

Myself I'm using this to override it to port 8080:

HEALTHCHECK --interval=10s --timeout=5s --retries=3 \
  CMD nc -z localhost 8080 || exit 1

Without it I had my images roll back, as they didn't report as healthy.

peytonyip commented 4 months ago

Thanks for your advice

ecker00 commented 4 months ago

Perfect, was stuck on this for a while, good to have it documented for everyone. 👍